MantisBT - Issues

0004990: Backgrounds for BBC buttons not showing when theme's name contains a space

Tue, 02 Apr 2013 13:50:06 -0400

When creating/editing a topic where there's a space in the name of the theme, you will get some Javascript errors saying that bbc_bg.gif could not be created.

In the GenericControls.template.php, this one will fail (#218):
sButtonBackgroundImage: ', JavaScriptEscape($settings['images_url'] . '/bbc/bbc_bg.gif'), '

0005023: html bbc is not prevented by nobbc

Sun, 10 Mar 2013 16:26:18 -0400

If you use the nobbc tag, it should stop any BBC tag from being executed.
However, the html tag is still executed.

0003936: [WYSIWYG] Status of BBC buttons does not update until you begin typing

Sat, 16 Feb 2013 14:37:46 -0500

http://www.simplemachines.org/community/index.php?topic=345188.0 [^]

"When using the editor, the bbc icon should stay in a state of being pressed until you press it again. For example lets say you press bold (while in the WYSWIYG editor,) the BBC hover image won't show until you start typing. This has been something that annoyed me for quite some time."

0005022: Upload for stars

Fri, 01 Feb 2013 12:42:48 -0500

action=admin;area=membergroups;sa=edit;group=1

There should be an upload system for new stars.

0005019: Counterproductive code in MessageIndex.php and Subs-Boards.php

Fri, 01 Feb 2013 12:27:40 -0500

The problem is the option to display avatars on the board index and message index. The option itself is fine. The way it's currently coded aint.

Generally, themers are going to want avatars in those areas to be significantly smaller than avatars next to posts. Somewhere around 40% would be about right. This means they'll need to write custom css anyway, to resize the avatars in those areas. That in turn means that the last thing they'll want to deal with is having inline dimensions forced via Sources. Trust me on this. The following code should be removed from Subs-Boards.php and MessageIndex.php:

if (!empty($settings['avatars_on_indexes']))
{
// Allow themers to show the latest poster's avatar along with the board
if(!empty($row_board['avatar']))
{
if ($modSettings['avatar_action_too_large'] == 'option_html_resize' || $modSettings['avatar_action_too_large'] == 'option_js_resize')
{
$avatar_width = !empty($modSettings['avatar_max_width_external']) ? ' width="' . $modSettings['avatar_max_width_external'] . '"' : '';
$avatar_height = !empty($modSettings['avatar_max_height_external']) ? ' height="' . $modSettings['avatar_max_height_external'] . '"' : '';
}
else
{
$avatar_width = '';
$avatar_height = '';
}
}
}

0005009: Critical Paid Subscriptions issue coming soon for paypal subscriptions

Tue, 15 Jan 2013 02:43:48 -0500

Paypal is doing an update on Feb 1, 2013 which affects how SMF handles paypal subscriptions.
Link: https://www.x.com/content/bulletin-ipn-and-pdt-scripts-and-http-1-1 [^]

https://www.x.com/content/bulletin-ipn-and-pdt-scripts-and-http-1-1 [^]

A fix must be rolled out before that time the sooner the better
My example fix

$header = 'POST /cgi-bin/webscr HTTP/1.1' . "\r\n";
$header .= 'Content-Type: application/x-www-form-urlencoded' . "\r\n";
$header .="Host: www." . (!empty($modSettings['paidsubs_test']) ? 'sandbox.' : '') . "paypal.com\r\n";
$header .= "Content-Length: " . strlen($requestString) . "\r\n";
$header .="Connection: close\r\n\r\n";

0004931: unserialze don't work correct with multibyte utf8 strings

Sat, 12 Jan 2013 14:23:00 -0500

See also topic http://www.simplemachines.org/community/index.php?topic=464060.0 [^]
To solve that, add a function mb_unserialize($data) in (as example) Subs.php;

function mb_unserialize($data)
{
return unserialize(preg_replace('/s:(\d+):"([^"]*)";/se', "'s:'. strlen('\\2') .':\"\\2\";'", $data));
}

replace all unserialze to mb_unserialize

0005017: loadMemberContext() loads data indiscriminately

Thu, 13 Dec 2012 12:18:59 -0500

If you use loadMemberData with the "minimal" parameter then you will have lots of undefined errors because loadMemberContext() doesn't check if the data was loaded by loadMemberData, it just assumes it is.

The errors will only appear if you call loadMemberData before SMF do it itself.

0004998: POST/PREVIEW reversed

Thu, 13 Dec 2012 12:17:24 -0500

The POST and PREVIEW buttons are reversed in order from how SMF 2.0 has them. Which, while this means POST is aligned closest to the edge of the text box, the tabindex still selects POST first, which is not what the brain expects to happen (in Western cultures, we're trained to think and see from left to right).

0005012: Deprecated CSS for old menu toggle

Wed, 12 Dec 2012 00:36:02 -0500

We can ditch this lot.

/* To allow absoluting teh toggle innit. */
div#admin_menu {
position: relative;
padding-right: 50px;
}
/* The dropdown menu toggle image */
#menu_toggle {
position: absolute;
z-index: 5;
right: 2px;
padding: 5px 9px 2px 9px;
background: #e3e9ef url(../images/theme/lower_section.png) 0 100% repeat-x;
border: 1px solid #bbb;
border-bottom: 1px solid #aaa;
border-radius: 4px;
}
.adm_section h4 img {
float: right;
margin: 0 1px;
padding: 3px 3px 0 3px;
border: 1px solid #ccc;
border-radius: 4px;
background: #e3e9ef;
}
#menu_toggle:hover, .adm_section h4 img:hover {
background: #fff url(../images/theme/lower_section.png) 0 30% repeat-x;
}

0005001: Login error with non-ascii charaters

Wed, 05 Dec 2012 15:16:04 -0500

In SMF usernames are not case sensitive when login. But if you give wrong size letter in username with non-ascii characters when login, smf gives password error in first attempt to try login. Second time works.

0004992: $pollinfo not defined in ssi_ShowPoll

Sat, 01 Dec 2012 14:39:10 -0500

In SSI.php
$pollinfo not defined in ssi_ShowPoll function in two spots code below should be $row instead of $pollinfo

'image' => empty($pollinfo['voting_locked']) ? 'poll' : 'locked_poll',
'question' => $row['question'],
'total_votes' => $total,
'is_locked' => !empty($pollinfo['voting_locked']),

0004897: Url/Iurl/automatically link urls for posts and topics applies to sigatures as well.

Fri, 23 Nov 2012 20:18:09 -0500

if you disable url/iurl bbc tag and/or automatically link posted url for posts/topics it also applies to signatures if you have url/iurl enabled, so sigs can not have valid links if topics/posts do not allow url/iurl

0004981: handling MS Smart Quotes

Fri, 23 Nov 2012 20:17:55 -0500

As reported by MrPhil: http://www.simplemachines.org/community/index.php?topic=475099 [^]

The support boards for all versions of SMF are clogged with reports of certain characters cutting off the rest of a post, or otherwise apparently causing mischief. The root cause of these problems is that people cut and paste text from Microsoft products (especially Word) that contain MS's "Smart Quotes", which are found only in CP-1252 encoding. My proposal is that all incoming text (from TEXT, TEXTAREA, and possibly other input fields) be scanned for Smart Quotes characters (binary), and any found should be replaced by HTML entities. str_replace() might do the job.

Read the topic. It has very nicely formatted description and a lot more text.

0004758: Ical feature needs some work

Fri, 23 Nov 2012 20:17:42 -0500

as found in http://www.simplemachines.org/community/index.php?topic=437891 [^] Ical has been a somewhat hidden feature, and in 2.0 has no way though the user interface to find the link required to use the feature. this should be resolved sometime in the future to aid users.

0005024: webinstall issue (always been there)

Tue, 20 Nov 2012 14:13:18 -0500

http://www.simplemachines.org/community/index.php?topic=491031.msg3441240#msg3441240 [^]

"OK - jag lägger ner projektet SMF.

Satte upp phpBB3 på fem minuter i stället."

Translated:
"I'll skip the SMF project, sat up phpBB in 5 minutes instead"

Yep, the webinstaller has always been broken. The issue is that the installer doesn't catch the right ftp path. In this guys situation, the forum was on mysite.com/forum and the webinstaller suggested the path /forum.

However, FTP access is very often (always for me on all hosts I have tried) going a step or two further out in the servers path.

Say you have a hosting here:
/home/www/public_html/mysite.com

The FTP client will show from (probably) /www/ :
public_html/mysite.com

So in that case, the path needs to be:
public_html/mysite.com/forum

The webinstaller needs to be an easy tool to use or there are no reasons to use it. If it can't detect the right path, people will not be able to use it!

I have also *never* on any server/VPS/free hosting/paid hosting been able to use localhost as FTP address and I have tried quite a few!
That text is unnessescary and confusing for people who don't know! "localhost" is suggested in the full installers as well. Remove it!

0005021: Unapproved Guest Post

Tue, 06 Nov 2012 03:35:36 -0500

Unapproved Guest Posts have a top margin issue...if it was as simple as just fixing the top margin, I'd take care of it.

But I have a feeling there's something wrong with the unapprove_bg or whatever.

0005003: Big code area

Tue, 06 Nov 2012 03:33:19 -0500

Code block seems a very big even if it contains only one string.

Solution: remove "height: 10em;" out from .bbc_code (index.css)

0005010: Message link in Display.template.php (you already had the fix)

Mon, 05 Nov 2012 09:06:56 -0500

Hey Ema, you gave me a fix for this one on my test site back at the end of July, but you never put it in the Github repo. :D

Problem is that the message links don't actually link to the right message if you copy/paste or click them. Fix is this:

Find:

// Show the message anchor and a "new" anchor if this message is new.
if ($message['id'] != $context['first_message'])
echo '
', $message['first_new'] ? '' : '';

echo '

';

Replace:

echo '

', $message['id'] != $context['first_message'] ? '
' . ($message['first_new'] ? '' : '') : '', '

';

Have attached a short php file just in case Mantis borks the code (as it loves to do).

0005016: Keyboard navigation appears to be broken on message index page

Mon, 05 Nov 2012 09:01:37 -0500

Ran across this one today. For some odd reason the problem only seems to be occurring on the message index. Other pages seem to be fine.

It's javascript-related, because disabling js fixes the problem. It's probably not related to any of our global js, because it only occurs on message index. There are no js errors showing on that page according to FF Web Dev.

0005018: Webkit.css is deprecated and should be deleted from the repo.

Thu, 01 Nov 2012 17:08:46 -0400

What the title says. Just noting it here so it doesn't get forgotten. :)

0004493: No describtion on subboards to redirects

Thu, 01 Nov 2012 16:53:24 -0400

When you create a sub board that redirects to another site, the describtion is nowhere to be seen.

0005004: "who is viewing" option doesn't work in topics

Thu, 01 Nov 2012 16:47:36 -0400

When "Show who is viewing the board index and posts" option is enabled, it doesn't work in topics.

$settings['display_who_viewing'] is not exist in Display.tempalte.php, why?

0004754: version check for theme install

Thu, 01 Nov 2012 11:41:52 -0400

Themes have a version number in their theme_info.xml but there is no version check that the theme will work with the version of the forum they are trying to install on. without this check many people attempt to install themes that are not for their version of smf, and therefore have issues reverting back as the menu among other things does not work correctly.

0005008: Impossible to report spammers without posts

Mon, 22 Oct 2012 18:56:23 -0400

If you, as regular member, comes across a potentional spammer, visiting his profile (if he has spam links in his signature), you can't report him as being spammer.