Advertisement:

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004214SMF 2.0Querypublic2010-03-06 18:112010-10-23 15:40
ReporterNorv 
PrioritylowSeveritymajorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0004214: Postgres installer on the same database returns errors
DescriptionI installed a SMF 2.0 rev. 9804 on a Postgres database where I already has a previous installation (different prefix).
==>
Your settings have now been saved and the database has been populated with all the data required to get your forum up and running. Summary of population:

Created 63 tables.
Inserted 945 rows.
Some of the queries were not executed properly. This could be caused by an unsupported (development or old) version of your database software.

Technical information about the queries:
Line #47: ERROR: syntax error at or near "." at character 215
Line #64: ERROR: cannot change return type of existing function
HINT: Use DROP FUNCTION first.
Line #130: ERROR: operator + already exists
Line #131: ERROR: operator <> already exists
Click "Continue" to progress to the admin account creation page.

Additional InformationI think the last 3 errors are clearly related to previous definitions of SQL procedures/operators, as the install script does for Postgres.
Not sure about the first, though.

IMHO, it can be considered low priority issue because I am not aware of support requests ever mentioning using 2 Postgres installations in the same database. Not the best reason, I know, please feel free to change it. But anyway, I set it as *major* (could be 'block' too, in fact) because I think it *didn't* result in the correct database structure, and I suspect SMF won't work properly - with a function returning another type than expected by the current SMF code etc.
Tags2.0 final
Attached Files

- Relationships

-  Notes
(0011697)
Norv (SMF Friend)
2010-03-06 18:14

Note: the previous installation was a RC2... or sort of early svn-version after RC2. (that's why the procedures don't match).
(0011700)
Oldiesmann (Developer)
2010-03-07 00:15

Thanks for the info Norv. I'll take a look at this in the next few days and see what I can do to fix it.
(0011703)
Oldiesmann (Developer)
2010-03-07 15:29

Did some more checking on these issues.

First error: I forgot to escape the single quotes in the second half of the "INET_ATON()" function query. Will commit a fix for this shortly.

Second error: This is due to the change with the find_in_set() function. I'm just going to let this one go for now and revisit the issue in the future if needed (hopefully we won't be adding/changing any more PostgreSQL functions at this point).

The last two errors should be ignored - we added code to install.php some time ago (possibly before RC1?) to make it ignore errors generated by CREATE OPERATOR queries. Will look further into this though.
(0011704)
Oldiesmann (Developer)
2010-03-07 15:38

! Forgot to escape single quotes (Revision 9805)
(0011706)
Norv (SMF Friend)
2010-03-08 03:29

Yes, I don't expect users will really need to actually run two Postgres installations, one on RC2, and another on RC3, necessarily in the same database.
(0012145)
Nao/Gilles (Viewer)
2010-06-08 05:32

Is this still a major block?

Who among the current dev team has access to a PGSQL server at all...?
(0012150)
Norv (SMF Friend)
2010-06-08 08:43

No, IMHO is not a block issue anymore... But two installations in the same database still cannot work (unless something changed meanwhile).
The thing is, there is no known case for the time being, either (the user base of SMF 2.0 on Postgres is small so far), and it would only happen if you install 2 forums of different versions in the same Postgres database (or a second forum RC3 forum without upgrading the first, or such), if I still understand this correctly.
(0012158)
Nao/Gilles (Viewer)
2010-06-08 10:09

If it were just up to me, I'd simply add a disclaimer for PGSQL users... :P
(0012892)
Norv (SMF Friend)
2010-09-04 14:51

I like the last idea more and more. :)
It is a rare case and the user should upgrade both installations anyway...
(0013122)
Nibogo (SMF Friend)
2010-10-06 09:48

This should be changed to minor, I don't think we should stop SMF 2.0 release because of a bug that isn't going to be replicated.
(0013130)
Norv (SMF Friend)
2010-10-07 05:03

Well the only reason why it's major is because in the rare cases when it could happen the installation of the second SMF will fail.

That said, tbh the first installation *should* be upgraded, and that would make everything work. (unless there's something else here than I see)
(0013278)
Nibogo (SMF Friend)
2010-10-21 22:57

Well for me isn't major as no-one would replicate it :P, if you can't fix it for 2.0 RC4, you could just add a little warning if Postgres was selected as the database. Just my $0.02
(0013287)
Norv (SMF Friend)
2010-10-23 15:40

& Notify about PostgreSQL of older and newer versions not supported in the same database. (install language file) Revision 10236
MantisBT 1.2.8 (Modified)[^] Copyright © 2000 - 2010 Mantis Group