Advertisement:
SMFPacks SEO Mod

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004311SMF 2.0Querypublic2010-05-30 06:162010-06-01 17:38
ReporterNao/Gilles 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0004311: db_list_columns vs. db_create_table
DescriptionAs described here:

http://www.simplemachines.org/community/index.php?topic=384073.0 [^]
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0012010)
Nao/Gilles (Viewer)
2010-05-30 06:18

Hmm, small bug in Mantis...
When I click "Change status to: assigned", it assigns it to "user0", rather than just me. Is it as expected...? How am I supposed to assign my own reports to myself? (This one would just serve as a reminder that I have to commit this at some point...)
(0012014)
Nao/Gilles (Viewer)
2010-05-30 17:59

! Added an extra test in db_create_table() to avoid script crashes when trying to create a table by using $db_query instead of {db_query}, as in earlier Betas and RC1. (DbPackages-mysql.php, DbPackages-postgresql.php, DbPackages-sqlite.php) Revision 9941
(0012016)
Norv (SMF Friend)
2010-05-31 05:27
edited on: 2010-05-31 05:27

I don't think I agree with this... If I understand it correctly, it helps an (old) usage of db_create_table() which is currently impossible or discouraged.
We should not be fixing code to be compatible with early Beta usages, as far as the software is in Beta there is no compatibility of this kind guaranteed. Sorry. IMHO adding stuff to core code to deal with mods written for Beta and not updated properly adds clutter.
I know, I will be shot by mod authors starting with you Nao, but I'll look at exactly what the delivery did sometimes later today.

(0012022)
Nao/Gilles (Viewer)
2010-06-01 17:38

(Reverted back to original behavior.)

(I love how I can now add comments without reopening a report. Yihaa.)
MantisBT 1.2.8 (Modified)[^] Copyright © 2000 - 2010 Mantis Group