Advertisement:
Anonymous Login
12-07-2016 09:22 AM

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0004354SMF 2.0Generalpublic2010-08-12 09:19
ReporterWindy 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
Summary0004354: Says new replies when posting when there aren't
DescriptionWasn't sure how to best describe this.

Hit preview when there are new replies
Then post

Expected: Post to go through normally
Result: Says there are new replies

I only just noticed it when I attempted to post on the forums here. Will need to test to confirm.
Additional InformationHere's the fix: http://dev.simplemachines.org/mantis/view.php?id=4397
Tags2.0 final, With Fix
Attached Files

-Relationships
related to 0004397resolved[SiNaN] Old posts added by ajax while posting shouldn't have "new" icon 
related to 0004400resolved[SiNaN] new replies does not take into account deleted posts when posting 
+Relationships

-Notes

bugnote:0012537

S-Ace (Beta Tester)

Woks fine with me,

bugnote:0012539

Windy (Viewer)

Was able to replicate by opening two separate browsers.

1. Send both browsers to the reply page of a topic
2. have one of them post
3. hit preview for the one that hasn't posted yet, the post from the other browser should show up at the bottom and the warning message about new replies appears
4. press post

bugnote:0012540

S-Ace (Beta Tester)

ok, can be reproduced all the time

But seems fine to me, when a one member posts and another member is writing a post at the same time, the 1st post is still unread, even though its shown when previewing the post. But its still unread, unless you scroll down and read it.

right ?

bugnote:0012542

Windy (Viewer)

yes, but at that point you've already been given the opportunity to read it before you post, if you don't care to read it or have already read it then a second warning is just an annoyance.

bugnote:0012544

Norv (SMF Friend)

I thought the same as Windy, I found it annoying, when I experienced it. (actually I am experiencing it quite often because I write long posts quite a number of times, and use Preview a lot).

bugnote:0012546

S-Ace (Beta Tester)

Personally i don't like the notification at all, and i always turn of the new replies notification,

So whats it going to be ? bug or no bug ?
Cuase the option to get rid of it is already available.

bugnote:0012547

Norv (SMF Friend)

IMHO, in case you do choose to be notified of replies, and are notified of replies along with the possibility of reading them, it should count as reading them.

(if you weren't notified, so they weren't displayed on your page to read them, then of course ... you didn't read them, so that one is not a problem).

bugnote:0012665

Nibogo (Viewer)

Attached a patch that fix this issue with a new $_SESSION['num_replies_'.$topic] variable. I'm not sure if it's the best way to fix this but it works and don't throw any error.

bugnote:0012707

Nibogo (Viewer)

Last edited: 2010-07-29 23:07

Moved patch: http://dev.simplemachines.org/mantis/view.php?id=4397 as it fix this and other issues.

bugnote:0012740

Windy (Viewer)

It probably would work, my only concern there would be issues if the user had multiple reply windows open for the same topic.

bugnote:0012741

Norv (SMF Friend)

I do happen to do that! :)

bugnote:0012784

[SiNaN] (Viewer)

 * The warning for new replies while posting did not consider replies displayed by previewing as read. (SSI.php, Display.php, Post.php, Display template, Post template, Xml template) Revision 10060

bugnote:0012788

Nao/Gilles (Viewer)

Bug fix...

Index: Sources/Post.php
===================================================================
--- Sources/Post.php (revision 10060)
+++ Sources/Post.php (working copy)
@@ -385,6 +385,7 @@
                 array(
                     'current_topic' => $topic,
                     'last_msg' => (int) $_REQUEST['last_msg'],
+ 'approved' => 1,
                 )
             );
             list ($context['new_replies']) = $smcFunc['db_fetch_row']($request);

bugnote:0012790

[SiNaN] (Viewer)

Fixed with rev 1061. Thanks!
+Notes
MantisBT (Modified for SMF Intergration)[^] Copyright © 2000 - 2010 Mantis Group