0004354: Says new replies when posting when there aren't

(0012537)
S-Ace (Beta Tester)
2010-07-16 03:15

Woks fine with me,

(0012539)
Windy (Beta Tester)
2010-07-16 05:02

Was able to replicate by opening two separate browsers.

1. Send both browsers to the reply page of a topic
2. have one of them post
3. hit preview for the one that hasn't posted yet, the post from the other browser should show up at the bottom and the warning message about new replies appears
4. press post

(0012540)
S-Ace (Beta Tester)
2010-07-16 06:01

ok, can be reproduced all the time

But seems fine to me, when a one member posts and another member is writing a post at the same time, the 1st post is still unread, even though its shown when previewing the post. But its still unread, unless you scroll down and read it.

right ?

(0012542)
Windy (Beta Tester)
2010-07-16 07:38

yes, but at that point you've already been given the opportunity to read it before you post, if you don't care to read it or have already read it then a second warning is just an annoyance.

(0012544)
Norv (Developer)
2010-07-16 09:05

I thought the same as Windy, I found it annoying, when I experienced it. (actually I am experiencing it quite often because I write long posts quite a number of times, and use Preview a lot).

(0012546)
S-Ace (Beta Tester)
2010-07-16 10:40

Personally i don't like the notification at all, and i always turn of the new replies notification,

So whats it going to be ? bug or no bug ?
Cuase the option to get rid of it is already available.

(0012547)
Norv (Developer)
2010-07-16 11:26

IMHO, in case you do choose to be notified of replies, and are notified of replies along with the possibility of reading them, it should count as reading them.

(if you weren't notified, so they weren't displayed on your page to read them, then of course ... you didn't read them, so that one is not a problem).

(0012665)
Nibogo (Team Member)
2010-07-23 23:48

Attached a patch that fix this issue with a new $_SESSION['num_replies_'.$topic] variable. I'm not sure if it's the best way to fix this but it works and don't throw any error.

(0012707)
Nibogo (Team Member)
2010-07-29 22:41
edited on: 2010-07-29 23:07

Moved patch: http://dev.simplemachines.org/mantis/view.php?id=4397 [^] as it fix this and other issues.

(0012740)
Windy (Beta Tester)
2010-08-02 03:00

It probably would work, my only concern there would be issues if the user had multiple reply windows open for the same topic.

(0012741)
Norv (Developer)
2010-08-02 06:18

I do happen to do that! :)

(0012784)
[SiNaN] (Developer)
2010-08-07 07:58

* The warning for new replies while posting did not consider replies displayed by previewing as read. (SSI.php, Display.php, Post.php, Display template, Post template, Xml template) Revision 10060

(0012788)
Nao/Gilles (Viewer)
2010-08-09 12:59

Bug fix...

Index: Sources/Post.php
===================================================================
--- Sources/Post.php (revision 10060)
+++ Sources/Post.php (working copy)
@@ -385,6 +385,7 @@
                 array(
                     'current_topic' => $topic,
                     'last_msg' => (int) $_REQUEST['last_msg'],
+ 'approved' => 1,
                 )
             );
             list ($context['new_replies']) = $smcFunc['db_fetch_row']($request);

(0012790)
[SiNaN] (Developer)
2010-08-12 09:19

Fixed with rev 1061. Thanks!

News:

Simple Machines Bug and Feature Tracker

Notes
(0012537) S-Ace (Beta Tester) 2010-07-16 03:15	Woks fine with me,

(0012539) Windy (Beta Tester) 2010-07-16 05:02	Was able to replicate by opening two separate browsers. 1. Send both browsers to the reply page of a topic 2. have one of them post 3. hit preview for the one that hasn't posted yet, the post from the other browser should show up at the bottom and the warning message about new replies appears 4. press post

(0012540) S-Ace (Beta Tester) 2010-07-16 06:01	ok, can be reproduced all the time But seems fine to me, when a one member posts and another member is writing a post at the same time, the 1st post is still unread, even though its shown when previewing the post. But its still unread, unless you scroll down and read it. right ?

(0012542) Windy (Beta Tester) 2010-07-16 07:38	yes, but at that point you've already been given the opportunity to read it before you post, if you don't care to read it or have already read it then a second warning is just an annoyance.

(0012544) Norv (Developer) 2010-07-16 09:05	I thought the same as Windy, I found it annoying, when I experienced it. (actually I am experiencing it quite often because I write long posts quite a number of times, and use Preview a lot).

(0012546) S-Ace (Beta Tester) 2010-07-16 10:40	Personally i don't like the notification at all, and i always turn of the new replies notification, So whats it going to be ? bug or no bug ? Cuase the option to get rid of it is already available.

(0012547) Norv (Developer) 2010-07-16 11:26	IMHO, in case you do choose to be notified of replies, and are notified of replies along with the possibility of reading them, it should count as reading them. (if you weren't notified, so they weren't displayed on your page to read them, then of course ... you didn't read them, so that one is not a problem).

(0012665) Nibogo (Team Member) 2010-07-23 23:48	Attached a patch that fix this issue with a new $_SESSION['num_replies_'.$topic] variable. I'm not sure if it's the best way to fix this but it works and don't throw any error.

(0012707) Nibogo (Team Member) 2010-07-29 22:41 edited on: 2010-07-29 23:07	Moved patch: http://dev.simplemachines.org/mantis/view.php?id=4397 [^] as it fix this and other issues.

(0012740) Windy (Beta Tester) 2010-08-02 03:00	It probably would work, my only concern there would be issues if the user had multiple reply windows open for the same topic.

(0012741) Norv (Developer) 2010-08-02 06:18	I do happen to do that! :)

(0012784) [SiNaN] (Developer) 2010-08-07 07:58	* The warning for new replies while posting did not consider replies displayed by previewing as read. (SSI.php, Display.php, Post.php, Display template, Post template, Xml template) Revision 10060

(0012788) Nao/Gilles (Viewer) 2010-08-09 12:59	Bug fix... Index: Sources/Post.php =================================================================== --- Sources/Post.php (revision 10060) +++ Sources/Post.php (working copy) @@ -385,6 +385,7 @@ array( 'current_topic' => $topic, 'last_msg' => (int) $_REQUEST['last_msg'], + 'approved' => 1, ) ); list ($context['new_replies']) = $smcFunc['db_fetch_row']($request);

(0012790) [SiNaN] (Developer) 2010-08-12 09:19	Fixed with rev 1061. Thanks!