Advertisement:

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004723SMF 2.1[SMF 2.0] Generalpublic2011-05-17 15:472013-10-26 23:18
ReporterIllori 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0004723: Admin Panel search does not check for enabled/disabled core features
DescriptionIf you search for a term in the admin panel you will presented with a list of possible matched terms, these terms will match even if you have a core option disabled
Steps To Reproduceinstall clean trunk or RC5
verify that paid subscriptions is disabled in core features
go back to main admin page and search for the term email

the last 3 selections are for the paid subscriptions feature

Send Notification Emails [Setting]
Email for Correspondence [Setting]
Paypal email address [Setting]
Additional InformationIf you have a core feature disabled links to their settings should not show up ideally in the admin panel search.

this can also be duplicated by searching for search engine when search engine tracking is disabled the 3rd result shows the same issue
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0013947)
Labradoodle-360 (SMF Friend)
2011-05-17 15:48

My guess would this should either not show up in the search, or redirect to core features.
(0013948)
Antechinus (SMF Friend)
2011-05-17 19:18

Ideally this would not happen, but given how minor it is and how late in our schedule we are now, I suggest this be left for 2.1.
(0013956)
Norv (SMF Friend)
2011-05-18 21:48

I'm not sure the results should not appear... It can useful when you forgot or don't know where/what they are.
(0013957)
Illori (Project Support)
2011-05-18 21:50

well the problem is those links just lead you to the admin main page which is not where the link should direct you to when the core features are enabled. when they are enabled they direct you to the correct page, so when you have a core feature disabled the search should not find anything that is for a feature that is disabled.
(0013961)
Norv (SMF Friend)
2011-05-20 01:50

Yes, if they appear in search, they should then appear as greyed out and without links directing to anything. Not release-critical.
(0014470)
emanuele (Developer)
2012-03-03 08:47
edited on: 2012-03-03 10:04

Commit: 1089407d42db05103b3b98fccf822fde97cb7bc1
Message: ! when few admin pages (some core features and custom smiley and message icons) are disabled the page is no more accessible [Bug 4723]
Author: emanuele
Date: 22/02/2012

(0014559)
emanuele (Developer)
2012-04-30 16:18

The original problem is a bit more complex to solve.

The three settings are get because of this:
    [0] => paid_email
    [1] => area=paidsubscribe;sa=settings

the code checks that the searched term is present in [0] and email is found.

Calendar related settings are instead similar to:
        (
            [0] => cal_days_for_index
            [1] => area=managecalendar;sa=settings
        )

so, if the search is cal all the calendar setting will appear.

So the result is rather...random...

Ideas?
(0014854)
arrowtotheknee (Developer)
2013-10-26 23:18

2.1 doesn't have a core features page now anyway.
MantisBT 1.2.8 (Modified)[^] Copyright © 2000 - 2010 Mantis Group