Advertisement:
NameCheap

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004751SMF 2.1[All Projects] public2011-06-13 20:072012-02-18 16:53
ReporterAntechinus 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0004751: Minor typos in ManageNews.template.php
Description            <div class="floatleftpadding">
                <div id="moreNewsItems_link" style="display: none;">javascript:void(0);</div>
                <script type="text/javascript"><!-- // --><![CDATA[
                    document.getElementById("moreNewsItems_link").style.display = "";
                    function addNewsItem()
                    {
                        document.getElementById("moreNews").style.display = "";
                        setOuterHTML(document.getElementById("moreNewsItems"), \'<div style="margin-bottom: 2ex;"><textarea rows="3" cols="65" name="news[]" style="' . ($context['browser']['is_ie8'] ? 'width: 635px; max-width: 85%; min-width: 85%' : 'width: 85%') . ';"><\' + \'/textarea><\' + \'/div><div id="moreNewsItems"><\' + \'/div>\');
                    }
                // ]]></script>
                <noscript>
                    <div style="margin-bottom: 2ex;"><textarea rows="3" cols="65" style="' . ($context['browser']['is_ie8'] ? 'width: 635px; max-width: 85%; min-width: 85%' : 'width: 85%') . ';" name="news[]"></textarea></div>
                </noscript>
            </div>
            <div class="floatrightpadding">

Should be:

            <div class="floatleft padding">
                <div id="moreNewsItems_link" style="display: none;">javascript:void(0);</div>
                <script type="text/javascript"><!-- // --><![CDATA[
                    document.getElementById("moreNewsItems_link").style.display = "";
                    function addNewsItem()
                    {
                        document.getElementById("moreNews").style.display = "";
                        setOuterHTML(document.getElementById("moreNewsItems"), \'<div style="margin-bottom: 2ex;"><textarea rows="3" cols="65" name="news[]" style="' . ($context['browser']['is_ie8'] ? 'width: 635px; max-width: 85%; min-width: 85%' : 'width: 85%') . ';"><\' + \'/textarea><\' + \'/div><div id="moreNewsItems"><\' + \'/div>\');
                    }
                // ]]></script>
                <noscript>
                    <div style="margin-bottom: 2ex;"><textarea rows="3" cols="65" style="' . ($context['browser']['is_ie8'] ? 'width: 635px; max-width: 85%; min-width: 85%' : 'width: 85%') . ';" name="news[]"></textarea></div>
                </noscript>
            </div>
            <div class="floatright padding">
Additional InformationSuggested temporary fix, for anyone who wants it right but doesn't want to hack templates on their installation of 2.0, is to add this to index.css:

/* Additional classes to fix Antiheinous's norty typos in ManageNews.template.php
/* Antiheinous shouldn't do svn commits late at night.
/* Mind you, nobody else spotted it either. :P */
.floatleftpadding
{
    padding: 0.5em;
    float: left;
}
.floatrightpadding
{
    padding: 0.5em;
    float: right;
}
/* End Antiheinous norty typos stuff. */
Tags2.1
Attached Files

- Relationships

-  Notes
(0014238)
Antechinus (SMF Friend)
2011-10-24 05:24

Fixed in 10843.
(0014413)
Spuds (SMF Friend)
2012-02-18 16:53

Commit:be0d46cb3ca8b16f8ec21c879e861b543c117f77

! Fixed a few minor bugs. (index.css, admin.css, ManageNews.template.php)[Bug 4751][Bug 4765][Bug 4779]
MantisBT 1.2.8 (Modified)[^] Copyright © 2000 - 2010 Mantis Group