Advertisement:
| Anonymous | Login | 05-21-2013 05:38 AM |  |
| My View | View Issues |
| View Issue Details [ Jump to Notes ] | [ Print ] | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |
| 0004789 | SMF 2.1 | Template | public | 2011-07-05 19:46 | 2012-06-01 18:15 | |
| Reporter | Antechinus | |||||
| Priority | normal | Severity | minor | Reproducibility | N/A | |
| Status | resolved | Resolution | fixed | |||
| Platform | OS | OS Version | ||||
| Summary | 0004789: Quickbuttons markup not the best for custom theming. | |||||
| Description | Bit of a balls up, in retrospect. Taking a random example: <li class="approve_button">lotsa_blah'; with css as: ul.quickbuttons li.approve_button { background: url(../images/theme/quickbuttons.png) no-repeat 0 -90px; } Eh wot? Bugger and grumble. Problem here is that this borks things if you want a buttonish background for the quickbuttons. What would be better markup is this: with css as: ul.quickbuttons li a.approve_button { background: url(../images/theme/quickbuttons.png) no-repeat 0 -90px; } That would allow setting a general buttonish background for ul.quickbuttons li and ul.quickbuttons li:hover with minimal css, and would also allow infernal piles of bat poo (like IE8) to have buttonish backgrounds and icons on the quickbuttons. ETA: For some reason Mantis isn't displaying the full markup in the examples, even though it's all there in the edit window. I've seen this before and it seems to be a bug in Mantis. It seems to be related to line breaks. What the hell use is a bug tracker that wont display code? | |||||
| Tags | 2.1 | |||||
| Attached Files | ||||||
 Relationships |
|
 Relationships |
|
Notes |
|
|
(0014620) Spuds (Developer) 2012-06-01 18:15 |
Commit:3d88329116d2957fe677e501377378c0905b97cf * ! 0004789: Quickbuttons markup not the best for custom theming. |
|
Notes |