Advertisement:
NameCheap

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004789SMF 2.1Templatepublic2011-07-05 19:462012-06-01 18:15
ReporterAntechinus 
PrioritynormalSeverityminorReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0004789: Quickbuttons markup not the best for custom theming.
DescriptionBit of a balls up, in retrospect. Taking a random example:

<li class="approve_button">lotsa_blah';

with css as:

ul.quickbuttons li.approve_button
{
    background: url(../images/theme/quickbuttons.png) no-repeat 0 -90px;
}

Eh wot? Bugger and grumble. Problem here is that this borks things if you want a buttonish background for the quickbuttons. What would be better markup is this:

  • lotsa_blah
  • ';

    with css as:

    ul.quickbuttons li a.approve_button
    {
        background: url(../images/theme/quickbuttons.png) no-repeat 0 -90px;
    }

    That would allow setting a general buttonish background for ul.quickbuttons li and ul.quickbuttons li:hover with minimal css, and would also allow infernal piles of bat poo (like IE8) to have buttonish backgrounds and icons on the quickbuttons.

    ETA: For some reason Mantis isn't displaying the full markup in the examples, even though it's all there in the edit window. I've seen this before and it seems to be a bug in Mantis. It seems to be related to line breaks.

    What the hell use is a bug tracker that wont display code?

    Tags2.1
    Attached Files

    - Relationships

    -  Notes
    (0014620)
    Spuds (SMF Friend)
    2012-06-01 18:15

    Commit:3d88329116d2957fe677e501377378c0905b97cf

    * ! 0004789: Quickbuttons markup not the best for custom theming.
    MantisBT 1.2.8 (Modified)[^] Copyright © 2000 - 2010 Mantis Group