Advertisement:
NameCheap

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004806SMF 2.0Templatepublic2011-07-19 22:022012-08-18 08:21
ReporterAkyhne 
PrioritynormalSeveritytweakReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0004806: Missing theme_variant_url on boardindex as guest
DescriptionButtons are the same, logged in or not. But as guest, the $context['theme_variant_url'] is missing.

http://www.simplemachines.org/community/index.php?topic=443168.0 [^]
TagsNo tags attached.
Attached Filestxt file icon grep_variant.txt [^] (41,366 bytes) 2012-06-30 12:16 [Show Content]

- Relationships

-  Notes
(0014637)
Akyhne (SMF Friend)
2012-06-25 18:03

Bump!
(0014643)
emanuele (Developer)
2012-06-30 12:15

Doing a grep for:
\$settings\['images_url'\], '\/[^']
I see a lot of places where variants are not taken in consideration (see the attachment).
Should be added somewhere else?
(0014644)
Akyhne (SMF Friend)
2012-07-01 18:14

The $context['theme_variant_url'] is not doing the same as $settings['images_url'].

I can't read the post I linked to, so I can't remember what the problem was and what should be fixed. But it's a one-spot only issue.
(0014645)
emanuele (Developer)
2012-07-01 18:24

I'll move the topic to bug reports.

If you open the file I attached to this issue there is the full list:
http://dev.simplemachines.org/mantis/file_download.php?file_id=814&type=bug [^]
(0014646)
Akyhne (SMF Friend)
2012-07-01 18:43

Problem is that this part....
        echo '
    <div id="posting_icons" class="flow_hidden">
        <ul class="reset">
            <li class="floatleft"><img src="', $settings['images_url'], '/new_none.png" alt="" /> ', $txt['old_posts'], '
            <li class="floatleft"><img src="', $settings['images_url'], '/new_redirect.png" alt="" /> ', $txt['redirect_board'], '
        
    </div>';

... is missing the $context['theme_variant_url'] after the $settings['images_url']
(0014647)
emanuele (Developer)
2012-07-01 19:14

So the other 150 places where $settings['theme_variant_url'] is *not* used are not of any interest for variants?
Good.
I'll fix only those two lines tomorrow.
(0014648)
Akyhne (SMF Friend)
2012-07-01 19:24

They are missing only in that spot because if you are logged in, the link to "no new posts" is like...

/Themes/WoW-DK_2/images/_Blood Elves/new_none.png

... and when logged out the link - with the same variant and everything - will look like...

/Themes/WoW-DK_2/images/new_none.png

When logged in...:
<li class="floatleft"><img src="', $settings['images_url'], '/', $context['theme_variant_url'], 'new_some.png" alt="" /> ', $txt['new_posts'], '
<li class="floatleft"><img src="', $settings['images_url'], '/', $context['theme_variant_url'], 'new_none.png" alt="" /> ', $txt['old_posts'], '
<li class="floatleft"><img src="', $settings['images_url'], '/', $context['theme_variant_url'], 'new_redirect.png" alt="" /> ', $txt['redirect_board'], '

When not...:
<li class="floatleft"><img src="', $settings['images_url'], '/new_none.png" alt="" /> ', $txt['old_posts'], '
<li class="floatleft"><img src="', $settings['images_url'], '/new_redirect.png" alt="" /> ', $txt['redirect_board'], '
MantisBT 1.2.8 (Modified)[^] Copyright © 2000 - 2010 Mantis Group