Advertisement:
A2Hosting

View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004874SMF 2.1[All Projects] Generalpublic2011-11-13 11:262012-06-01 09:32
Reportergroundup 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Summary0004874: RSS Author field should show author name
Descriptionhttp://www.simplemachines.org/community/index.php?topic=360355.0 [^]

This is a very minor issue, and causes no errors at all to the majority of feed readers. However, it is very easy to fix, so I'm reporting it in anyway.

Basically, in SMF RSS feeds, the 'author' node is generated and populated with an email address. The format should be <author>[email address] ([name])</author>.

http://www.rssboard.org/rss-specification#ltauthorgtSubelementOfLtitemgt [^]
Additional InformationTo fix this (minor) semantic error, replace all instances of:

Code: [Select]
'author' => (!empty($modSettings['guest_hideContacts']) && $user_info['is_guest']) || (!empty($row['hideEmail']) && !empty($modSettings['allow_hideEmail']) && !allowedTo('moderate_forum')) ? null : $row['posterEmail'],

with
Code: [Select]
'author' => (!empty($modSettings['guest_hideContacts']) && $user_info['is_guest']) || (!empty($row['hideEmail']) && !empty($modSettings['allow_hideEmail']) && !allowedTo('moderate_forum')) ? null : $row['posterEmail'] . ' ('.$row['posterName'].')',
Tags2.1
Attached Files

- Relationships

-  Notes
(0014614)
emanuele (Developer)
2012-06-01 09:32

commit 2f5f01d9150c23a1694c2131bc56eed9b8fba480
Author: emanuele
Date: Fri Jun 1 2012

    rss author tag now shows also the name [Bug 4874]
    Fixed (I hope) the atom feeds
    Changed from rss to rss2 (2 because...don't know, it's new maybe :P) the default feed and added atoms too
MantisBT 1.2.8 (Modified)[^] Copyright © 2000 - 2010 Mantis Group