Simple Machines Bug and Feature Tracker
|Anonymous | Login||05-20-2013 01:39 AM|
|My View | View Issues|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0004911||SMF 2.1||[All Projects] General||public||2011-12-20 06:44||2012-10-14 18:48|
|Summary||0004911: Theme compability and upgrade.php|
|Description||when there are major changes in themes between versions the upgrade.php script should offer to the admin the ability to reset the default theme to "default" as many custom themes from old versions dont work with the newer versions. Not always are the admin users able to access the admin panel due to theme changes and not always will adding ?theme=1 work to reset the theme.|
MantisBT 1.2.8 (Modified)[^] Copyright © 2000 - 2010 Mantis Group
|Looking at the code in upgrade.php I noticed the code that should remove the mods from installed themes...does it make sense to try to uninstall mods from themes that very likely will not work anyway?|
I wouldn't. Not for major version changes. It's just one more thing to go wrong with the upgrade, and the script is heavily loaded already on largish sites.
If an admin wants to keep a custom theme, they can easily upload the vanilla files they got with the theme in the first place, just as they have to upload new default theme files, etc.